Split common.sh into separate scripts for each job#5569
Merged
earlephilhower merged 1 commit intoesp8266:masterfrom Jan 9, 2019
Androbin:split-common
Merged
Split common.sh into separate scripts for each job#5569earlephilhower merged 1 commit intoesp8266:masterfrom Androbin:split-common
earlephilhower merged 1 commit intoesp8266:masterfrom
Androbin:split-common
Conversation
earlephilhower
requested changes
Jan 8, 2019
Collaborator
earlephilhower
left a comment
earlephilhower
left a comment
There was a problem hiding this comment.
@Androbin Thanks for the PR, but there have been changes done recently to speed up CI pretty massively and this no longer merges or works with the new caching setup.
You'd need to make the cache_dir defined inside the individual run units, adjust the calls and common.sh functions to take cache_dir as a parameter, and redo the ordering in travis.yaml since that also sped things up wall-time-wise.
Contributor
Author
|
@earlephilhower Done. BTW no need to pass |
earlephilhower
approved these changes
Jan 9, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes the TODO created by @igrr in #5474.
By the way, the
BUILD_TYPEvaluespackage,hostandstyleseem to be unhandled?